[PATCH v2] riscv/purgatory: align riscv_kernel_entry

Matthias Brugger matthias.bgg at kernel.org
Thu Jul 18 08:16:37 PDT 2024


On Tue, Jul 16, 2024 at 10:40:47PM +0200, Daniel Maslowski wrote:
> When alignment handling is delegated to the kernel, everything must be
> word-aligned in purgatory, since the trap handler is then set to the
> kexec one. Without the alignment, hitting the exception would
> ultimately crash. On other occasions, the kernel's handler would take
> care of exceptions.
> This has been tested on a JH7110 SoC with oreboot and its SBI delegating
> unaligned access exceptions and the kernel configured to handle them.
> 
> Fixes: 736e30af583fb6e0e2b8211b894ff99dea0f1ee7
Should be:

Fixes: 736e30af583fb ("RISC-V: Add purgatory")

Regards,
Matthias

> Signed-off-by: Daniel Maslowski <cyrevolt at gmail.com>
> ---
>  arch/riscv/purgatory/entry.S | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/riscv/purgatory/entry.S b/arch/riscv/purgatory/entry.S
> index 5bcf3af903da..0e6ca6d5ae4b 100644
> --- a/arch/riscv/purgatory/entry.S
> +++ b/arch/riscv/purgatory/entry.S
> @@ -7,6 +7,7 @@
>   * Author: Li Zhengyu (lizhengyu3 at huawei.com)
>   *
>   */
> +#include <asm/asm.h>
>  #include <linux/linkage.h>
>  
>  .text
> @@ -34,6 +35,7 @@ SYM_CODE_END(purgatory_start)
>  
>  .data
>  
> +.align LGREG
>  SYM_DATA(riscv_kernel_entry, .quad 0)
>  
>  .end
> -- 
> 2.45.2
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv



More information about the linux-riscv mailing list