[PATCH v2 1/3] dt-bindings: mailbox: add Sophgo cv18x SoCs mailbox
Conor Dooley
conor at kernel.org
Wed Jul 17 10:12:26 PDT 2024
On Thu, Jul 18, 2024 at 01:06:46AM +0800, Yuntao Dai wrote:
> > > > +examples:
> > > > + - |
> > > > + #include <dt-bindings/interrupt-controller/irq.h>
> > > > +
> > > > + mailbox: mailbox at 1900000 {
> >
> > And while you're fixing the things Inochi pointed out, drop the
> > "mailbox:" label, you've got no references to it.
> >
>
> Yes, in this patch there is no references to it, but mailbox client node
> will need it.
> I tested this patch using mailbox-test as the client, like:
> "
> mailbox-test {
> compatible = "mailbox-test";
> mbox-names = "rx", "tx";
> mboxes = <&mailbox 0 1 &mailbox 1 2>;
> };
> "
>
> If you think it is better to drop the label in this patch, I will drop it.
Just drop it from the example, you can keep it in the actual dts. We try
to keep these examples to a minimum.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20240717/99247dc9/attachment.sig>
More information about the linux-riscv
mailing list