[PATCH v2] riscv: dts: sophgo: add watchdog dt node for CV1800

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Thu Jan 25 04:39:51 PST 2024


On 25/01/2024 10:46, AnnanLiu wrote:
> +
> +		pclk: pclk {
> +			#clock-cells = <0>;
> +			compatible = "fixed-clock";
> +			clock-frequency = <25000000>;

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

Also, why do you describe internal clock as stub?

Best regards,
Krzysztof




More information about the linux-riscv mailing list