[PATCH] sh: use generic uaccess
John Paul Adrian Glaubitz
glaubitz at physik.fu-berlin.de
Tue Jan 23 06:18:13 PST 2024
Hi Arnd,
On Tue, 2024-01-23 at 15:14 +0100, Arnd Bergmann wrote:
> On Tue, Jan 23, 2024, at 14:55, John Paul Adrian Glaubitz wrote:
> >
> > Wouldn't that make these operations slower or do you think that GCC is able
> > to optimize this well enough?
>
> It's only single load/store instructions, so it should make no
> difference. If anything, the generic code should allow the compiler
> to have better register allocation and produce better output than
> the assembler version (which is how this avoids the ICE), but it's
> unlikely to be noticeably either.
I have not seen an ICE on v6.8-rc1 so far. What config was it that triggered it?
> > Also, this is something that should definitely be boot-tested to make sure
> > this doesn't introduce any regressions.
>
> Agree.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
More information about the linux-riscv
mailing list