[PATCH v6 3/3] riscv: dts: sophgo: add rtc dt node for CV1800

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Mon Jan 15 23:44:12 PST 2024


On 15/01/2024 17:06, Jingbao Qiu wrote:
> Add the rtc device tree node to cv1800 SoC.
> 
> Signed-off-by: Jingbao Qiu <qiujingbao.dlmu at gmail.com>
> ---
>  arch/riscv/boot/dts/sophgo/cv1800b.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/sophgo/cv1800b.dtsi b/arch/riscv/boot/dts/sophgo/cv1800b.dtsi
> index df40e87ee063..66bb4a752b91 100644
> --- a/arch/riscv/boot/dts/sophgo/cv1800b.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/cv1800b.dtsi
> @@ -119,5 +119,17 @@ clint: timer at 74000000 {
>  			reg = <0x74000000 0x10000>;
>  			interrupts-extended = <&cpu0_intc 3>, <&cpu0_intc 7>;
>  		};
> +
> +		rtc: rtc at 5025000 {
> +			compatible = "sophgo,cv1800-rtc", "syscon";
> +			reg = <0x5025000 0x2000>;
> +			interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&osc>;
> +		};
> +
> +		por {
> +			compatible = "sophgo,cv1800-por";

What is this? Why is it here, how did it even appear? It misses unit
address and reg or is clearly placed in wrong place. It seems you
entirely ignored out previous discussion.

NAK

Best regards,
Krzysztof




More information about the linux-riscv mailing list