[PATCH v10 2/4] pwm: opencores: Add PWM driver support

[William Qiu]

> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> Sent: 2024年1月5日 6:41
> To: William Qiu <william.qiu at starfivetech.com>
> Cc: devicetree at vger.kernel.org; linux-kernel at vger.kernel.org;
> linux-riscv at lists.infradead.org; linux-pwm at vger.kernel.org; Emil Renner
> Berthing <kernel at esmil.dk>; Rob Herring <robh+dt at kernel.org>; Thierry
> Reding <thierry.reding at gmail.com>; Philipp Zabel <p.zabel at pengutronix.de>;
> Krzysztof Kozlowski <krzysztof.kozlowski+dt at linaro.org>; Conor Dooley
> <conor+dt at kernel.org>; Hal Feng <hal.feng at starfivetech.com>; Paul
> Walmsley <paul.walmsley at sifive.com>; Palmer Dabbelt
> <palmer at dabbelt.com>; Albert Ou <aou at eecs.berkeley.edu>
> Subject: Re: [PATCH v10 2/4] pwm: opencores: Add PWM driver support
> 
> Hello again,
> 
> On Fri, Dec 22, 2023 at 05:45:46PM +0800, William Qiu wrote:
> > +static const struct ocores_pwm_data jh7100_pwm_data = {
> > +	.get_ch_base = starfive_jh71x0_get_ch_base, };
> > +
> > +static const struct ocores_pwm_data jh7110_pwm_data = {
> > +	.get_ch_base = starfive_jh71x0_get_ch_base, };
> > +
> > +static const struct of_device_id ocores_pwm_of_match[] = {
> > +	{ .compatible = "opencores,pwm-v1" },
> > +	{ .compatible = "starfive,jh7100-pwm", .data = &jh7100_pwm_data},
> > +	{ .compatible = "starfive,jh7110-pwm", .data = &jh7110_pwm_data},
> > +	{ /* sentinel */ }
> 
> Looking at the binding
> 
> 	compatible = "opencores,pwm-v1";
> 
> isn't a valid configuration. If that is indeed the case and you always have either
> starfive,jh7100-pwm or starfive,jh7110-pwm, you can drop the logic to only use
> starfive_jh71x0_get_ch_base conditionally.
> 
> Best regards
> Uwe
> 
> --
> Pengutronix e.K.                           | Uwe Kleine-König
> |
> Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Hi Uwe,

I just upload code for OpenCores.. And I need to add the starfive_jh71x0_get_ch_base
to compatibility with jh71x0. So even the "opencores,pwm-v1" isn't a valid
configuration, but I still need to add it for OpenCores.

Best Regards,
William