[PATCH 1/3] dt-bindings: mmc: sdhci-cadence6: add DT bindings documentation
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Thu Jan 4 01:28:56 PST 2024
On 28/12/2023 07:53, Alex Soo wrote:
> Add DT bindings documentation for Cadence SD/eMMC host controller
> (Version 6) driver.
>
> Signed-off-by: Alex Soo <yuklin.soo at starfivetech.com>
A nit, subject: drop second/last, redundant "DT bindings documentation".
The "dt-bindings" prefix is already stating that these are bindings.
Basically your subject is pure redundancy.
> ---
> .../devicetree/bindings/mmc/cdns,sd6hci.yaml | 65 +++++++++++++++++++
> 1 file changed, 65 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mmc/cdns,sd6hci.yaml
>
> diff --git a/Documentation/devicetree/bindings/mmc/cdns,sd6hci.yaml b/Documentation/devicetree/bindings/mmc/cdns,sd6hci.yaml
> new file mode 100644
> index 000000000000..97e28d720c7b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/cdns,sd6hci.yaml
There were several other patches adding this, so please consolidate the
effort. You just duplicated a lot of code.
Best regards,
Krzysztof
More information about the linux-riscv
mailing list