[PATCH] cpuidle: riscv-sbi: Add cluster_pm_enter()/exit()
Nick Hu
nick.hu at sifive.com
Sun Feb 25 22:51:13 PST 2024
When the cpus in the same cluster are all in the idle state, the kernel
might put the cluster into a deeper low power state. Call the
cluster_pm_enter() before entering the low power state and call the
cluster_pm_exit() after the cluster woken up.
Signed-off-by: Nick Hu <nick.hu at sifive.com>
---
drivers/cpuidle/cpuidle-riscv-sbi.c | 24 ++++++++++++++++++++++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/drivers/cpuidle/cpuidle-riscv-sbi.c b/drivers/cpuidle/cpuidle-riscv-sbi.c
index e8094fc92491..298dc76a00cf 100644
--- a/drivers/cpuidle/cpuidle-riscv-sbi.c
+++ b/drivers/cpuidle/cpuidle-riscv-sbi.c
@@ -394,6 +394,7 @@ static int sbi_cpuidle_pd_power_off(struct generic_pm_domain *pd)
{
struct genpd_power_state *state = &pd->states[pd->state_idx];
u32 *pd_state;
+ int ret;
if (!state->data)
return 0;
@@ -401,6 +402,10 @@ static int sbi_cpuidle_pd_power_off(struct generic_pm_domain *pd)
if (!sbi_cpuidle_pd_allow_domain_state)
return -EBUSY;
+ ret = cpu_cluster_pm_enter();
+ if (ret)
+ return ret;
+
/* OSI mode is enabled, set the corresponding domain state. */
pd_state = state->data;
sbi_set_domain_state(*pd_state);
@@ -408,6 +413,19 @@ static int sbi_cpuidle_pd_power_off(struct generic_pm_domain *pd)
return 0;
}
+static int sbi_cpuidle_pd_power_on(struct generic_pm_domain *pd)
+{
+ struct genpd_power_state *state = &pd->states[pd->state_idx];
+
+ if (!state->data)
+ return 0;
+
+ if (!sbi_cpuidle_pd_allow_domain_state)
+ return -EBUSY;
+
+ return cpu_cluster_pm_exit();
+}
+
struct sbi_pd_provider {
struct list_head link;
struct device_node *node;
@@ -433,10 +451,12 @@ static int sbi_pd_init(struct device_node *np)
pd->flags |= GENPD_FLAG_IRQ_SAFE | GENPD_FLAG_CPU_DOMAIN;
/* Allow power off when OSI is available. */
- if (sbi_cpuidle_use_osi)
+ if (sbi_cpuidle_use_osi) {
pd->power_off = sbi_cpuidle_pd_power_off;
- else
+ pd->power_on = sbi_cpuidle_pd_power_on;
+ } else {
pd->flags |= GENPD_FLAG_ALWAYS_ON;
+ }
/* Use governor for CPU PM domains if it has some states to manage. */
pd_gov = pd->states ? &pm_domain_cpu_gov : NULL;
--
2.34.1
More information about the linux-riscv
mailing list