回复: 回复: [v2] riscv: dts: starfive: jh7110: Add camera subsystem nodes

[Changhuang Liang]

Hi, Conor,

[...]
> > > > +	imx219_clk: imx219-clock {
> > > > +		compatible = "fixed-clock";
> > > > +		clock-output-names = "imx219_clk";
> > > > +		clock-frequency = <24000000>;
> > > > +		#clock-cells = <0>;
> > > > +	};
> > >
> > > Why do you need an output name here?
> >
> > The output name can be unnecessary.
> >
> > > Also, where does this clock come from? Is it an oscillator on the board?
> > >
> >
> > This clock come from imx219, not the VisionFive 2 board.
> 
> If the camera is not on the visionfive 2 board, why are you adding this to
> visionfive-2.dtsi?

It seems that I need to use dtso. Right?

regards
Changhuang