On Tue, Dec 24, 2024 at 7:49 AM Leyfoon Tan
<leyfoon.tan at starfivetech.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Anup Patel <apatel at ventanamicro.com>
> > Sent: Monday, December 16, 2024 4:48 PM
> > To: Michael Turquette <mturquette at baylibre.com>; Stephen Boyd
> > <sboyd at kernel.org>; Rob Herring <robh at kernel.org>; Krzysztof Kozlowski
> > <krzk+dt at kernel.org>; Conor Dooley <conor+dt at kernel.org>; Jassi Brar
> > <jassisinghbrar at gmail.com>
> > Cc: Palmer Dabbelt <palmer at dabbelt.com>; Paul Walmsley
> > <paul.walmsley at sifive.com>; Sunil V L <sunilvl at ventanamicro.com>; Rahul
> > Pathak <rpathak at ventanamicro.com>; Leyfoon Tan
> > <leyfoon.tan at starfivetech.com>; Atish Patra <atishp at atishpatra.org>;
> > Andrew Jones <ajones at ventanamicro.com>; Anup Patel
> > <anup at brainfault.org>; linux-clk at vger.kernel.org;
> > devicetree at vger.kernel.org; linux-riscv at lists.infradead.org; linux-
> > kernel at vger.kernel.org; Anup Patel <apatel at ventanamicro.com>
> > Subject: [RFC PATCH 2/8] dt-bindings: mailbox: Add bindings for RPMI shared
> > memory transport
> >
> [...]
>
> > +
> > +examples:
> > + - |
> > + // Example 1 (RPMI shared memory with only 2 queues):
> > + mailbox at 10080000 {
> > + compatible = "riscv,rpmi-shmem-mbox";
> > + reg = <0x00 0x10080000 0x00 0x10000>,
> > + <0x00 0x10090000 0x00 0x10000>,
> > + <0x00 0x100a0000 0x00 0x4>;
> > + reg-names = "a2p-req", "p2a-ack", "db-reg";
> > + msi-parent = <&imsic_mlevel>;
> > + riscv,slot-size = <64>;
> > + #mbox-cells = <1>;
> > + };
> > + - |
> > + // Example 2 (RPMI shared memory with only 4 queues):
> > + mailbox at 10001000 {
> > + compatible = "riscv,rpmi-shmem-mbox";
> > + reg = <0x00 0x10001000 0x00 0x800>,
> > + <0x00 0x10001800 0x00 0x800>,
> > + <0x00 0x10002000 0x00 0x800>,
> > + <0x00 0x10002800 0x00 0x800>,
> > + <0x00 0x10003000 0x00 0x4>;
> > + reg-names = "a2p-req", "p2a-ack", "db-reg";
>
> reg has 5 entries, missing 2 reg-names?
copy-paste error, thanks for catching.
Regards,
Anup
>
> > + msi-parent = <&imsic_mlevel>;
> > + riscv,slot-size = <64>;
> > + riscv,db-mask = <0x00008000>;
> > + riscv,db-value = <0x00008000>;
> > + #mbox-cells = <1>;
> > + };
> > --
> > 2.43.0
>
> Regards
> Ley Foon