[RFC PATCH v1 02/14] dt-bindings: clock: thead,th1520: Rename header file
Rob Herring (Arm)
robh at kernel.org
Tue Dec 3 06:24:57 PST 2024
On Tue, 03 Dec 2024 14:41:25 +0100, Michal Wilczynski wrote:
> As support for clocks from new subsystems is being added to the T-Head
> TH1520 SoC, the header file name should reflect this broader scope. The
> existing header file 'thead,th1520-clk-ap.h' includes the '-ap' suffix,
> indicating it's specific to the Application Processor (AP) subsystem.
>
> Rename the header file to 'thead,th1520-clk.h' to generalize it for all
> subsystems. Update all references to this header file accordingly.
>
> Signed-off-by: Michal Wilczynski <m.wilczynski at samsung.com>
> ---
> .../devicetree/bindings/clock/thead,th1520-clk-ap.yaml | 4 ++--
> .../devicetree/bindings/mailbox/thead,th1520-mbox.yaml | 2 +-
> MAINTAINERS | 2 +-
> arch/riscv/boot/dts/thead/th1520.dtsi | 2 +-
> drivers/clk/thead/clk-th1520.h | 2 +-
> .../clock/{thead,th1520-clk-ap.h => thead,th1520-clk.h} | 0
> 6 files changed, 6 insertions(+), 6 deletions(-)
> rename include/dt-bindings/clock/{thead,th1520-clk-ap.h => thead,th1520-clk.h} (100%)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/mailbox/thead,th1520-mbox.example.dts:24:18: fatal error: dt-bindings/clock/thead,th1520-clk.h: No such file or directory
24 | #include <dt-bindings/clock/thead,th1520-clk.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/mailbox/thead,th1520-mbox.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.example.dts:18:18: fatal error: dt-bindings/clock/thead,th1520-clk.h: No such file or directory
18 | #include <dt-bindings/clock/thead,th1520-clk.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/clock/thead,th1520-clk-ap.example.dtb] Error 1
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2
make: *** [Makefile:251: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241203134137.2114847-3-m.wilczynski@samsung.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
More information about the linux-riscv
mailing list