[PATCH] RISC-V: selftests: cbo: Ensure asm operands match constraints, take 2

Andrew Jones ajones at ventanamicro.com
Wed Apr 24 03:33:28 PDT 2024


On Wed, Apr 24, 2024 at 10:41:10AM +0100, Conor Dooley wrote:
> On Fri, Mar 22, 2024 at 02:47:28PM +0100, Andrew Jones wrote:
> > Commit 0de65288d75f ("RISC-V: selftests: cbo: Ensure asm operands
> > match constraints") attempted to ensure MK_CBO() would always
> > provide to a compile-time constant when given a constant, but
> > cpu_to_le32() isn't necessarily going to do that. Switch to manually
> > shifting the bytes, when needed, to finally get this right.
> > 
> > Reported-by: Woodrow Shen <woodrow.shen at sifive.com>
> > Closes: https://lore.kernel.org/all/CABquHATcBTUwfLpd9sPObBgNobqQKEAZ2yxk+TWSpyO5xvpXpg@mail.gmail.com/
> > Fixes: a29e2a48afe3 ("RISC-V: selftests: Add CBO tests")
> > Fixes: 0de65288d75f ("RISC-V: selftests: cbo: Ensure asm operands match constraints")
> > Signed-off-by: Andrew Jones <ajones at ventanamicro.com>
> 
> This has been sitting in patchwork for a while and I don't see a message
> from either the reporter saying this was a good fix or from the selftests
> maintainer that it has been picked up. I was gonna mark it "handled
> elsewhere" but I noticed that this was only sent to the riscv
> maintainers so we should probably harass Palmer today to pick this up?
> 

Yup. Thanks for the reminder to follow up!

drew



More information about the linux-riscv mailing list