Re: [PATCH] riscv: Kconfig.errata: Add dependency for RISCV_SBI in ERRATA_ANDES config

[Conor Dooley]

On 1 September 2023 12:03:20 IST, Prabhakar <prabhakar.csengg at gmail.com> wrote:
>From: Lad Prabhakar <prabhakar.mahadev-lad.rj at bp.renesas.com>
>
>Andes errata uses sbi_ecalll() which is only available if RISCV_SBI is
>enabled. So add an dependency for RISCV_SBI in ERRATA_ANDES config to
>avoid any build failures.
>
>Reported-by: kernel test robot <lkp at intel.com>
>Closes: https://lore.kernel.org/oe-kbuild-all/202308311610.ec6bm2G8-lkp@intel.com/
>Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj at bp.renesas.com>

This one needs to grow the same fixes tag.
Ideally the whole lot of kconfig bits would be in a series IMO.

>---
> arch/riscv/Kconfig.errata | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/arch/riscv/Kconfig.errata b/arch/riscv/Kconfig.errata
>index bee5d838763b..566bcefeab50 100644
>--- a/arch/riscv/Kconfig.errata
>+++ b/arch/riscv/Kconfig.errata
>@@ -2,7 +2,7 @@ menu "CPU errata selection"
> 
> config ERRATA_ANDES
> 	bool "Andes AX45MP errata"
>-	depends on RISCV_ALTERNATIVE
>+	depends on RISCV_ALTERNATIVE && RISCV_SBI
> 	help
> 	  All Andes errata Kconfig depend on this Kconfig. Disabling
> 	  this Kconfig will disable all Andes errata. Please say "Y"