[PATCH] riscv: defconfig: Regenerate defconfig

[Chanho Park]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk at kernel.org>
> Sent: Sunday, October 29, 2023 4:50 PM
> To: Chanho Park <chanho61.park at samsung.com>; Paul Walmsley
> <paul.walmsley at sifive.com>; Palmer Dabbelt <palmer at dabbelt.com>; Albert Ou
> <aou at eecs.berkeley.edu>
> Cc: linux-riscv at lists.infradead.org
> Subject: Re: [PATCH] riscv: defconfig: Regenerate defconfig
> 
> On 27/10/2023 13:35, Chanho Park wrote:
> > Run 'make defconfig savedefconfig' and copy the defconfig file to
> > arch/riscv/configs/defconfig.
> >
> > Signed-off-by: Chanho Park <chanho61.park at samsung.com>
> > ---
> >  arch/riscv/configs/defconfig | 10 +---------
> >  1 file changed, 1 insertion(+), 9 deletions(-)
> >
> > diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> > index ab86ec3b9eab..83fa02611284 100644
> > --- a/arch/riscv/configs/defconfig
> > +++ b/arch/riscv/configs/defconfig
> > @@ -27,15 +27,12 @@ CONFIG_EXPERT=y
> >  CONFIG_PROFILING=y
> >  CONFIG_SOC_MICROCHIP_POLARFIRE=y
> >  CONFIG_ARCH_RENESAS=y
> > -CONFIG_ARCH_THEAD=y
> >  CONFIG_SOC_SIFIVE=y
> >  CONFIG_SOC_STARFIVE=y
> >  CONFIG_ARCH_SUNXI=y
> > +CONFIG_ARCH_THEAD=y
> >  CONFIG_SOC_VIRT=y
> >  CONFIG_SMP=y
> > -CONFIG_HOTPLUG_CPU=y
> > -CONFIG_PM=y
> 
> User-selectible options should not be removed from defconfig via
> savedefconfig. Please do not run blind savedefconfig, unless you are
> okay with actually loosing these options. We discussed this multiple
> times...
> 
> https://lore.kernel.org/all/20201130202501.GA32878@kozik-lap/
> and some other threads
> 

I see. When I run savedefconfig, I always checked .config changes between old and new to avoid such missing.
I thought there were some things that needed to be fixed manually, which could lead to mistakes.
Also, if you make a mess with a manual update, it makes the next update harder.
Thanks for pointing that out and explaining the history :)

Best Regards,
Chanho Park