[PATCH 1/3] RISC-V: Don't fail in riscv_of_parent_hartid() for disabled HARTs

Anup Patel apatel at ventanamicro.com
Fri Oct 27 07:38:24 PDT 2023


On Fri, Oct 27, 2023 at 1:29 PM Thomas Gleixner <tglx at linutronix.de> wrote:
>
> On Wed, Oct 25 2023 at 19:58, Anup Patel wrote:
> > The riscv_of_processor_hartid() used by riscv_of_parent_hartid() fails
> > for HARTs disabled in the DT. This results in the following warning
> > thrown by the RISC-V INTC driver for the E-core on SiFive boards:
> >
> > [    0.000000] riscv-intc: unable to find hart id for /cpus/cpu at 0/interrupt-controller
> >
> > The riscv_of_parent_hartid() is only expected to read the hartid from
> > the DT so we should directly call of_get_cpu_hwid() instead of calling
>
> We should? Or maybe not?
>
> Please write precise changelogs and use imperative wording as documented
> in Documentation/process.

Sure, I will update the wording in the commit description.

Thanks,
Anup



More information about the linux-riscv mailing list