[PATCH 1/5] csky: remove unused cmd_vdso_install

Guo Ren guoren at kernel.org
Mon Oct 9 08:16:30 PDT 2023


On Mon, Oct 9, 2023 at 8:42 PM Masahiro Yamada <masahiroy at kernel.org> wrote:
>
> You cannot run this code because arch/csky/Makefile does not define the
> vdso_install target.
>
> It appears that this code was blindly copied from another architecture.
Yes, I do that. Thx for pointing it out.

Acked-by: Guo Ren <guoren at kernel.org>

>
> Remove the dead code.
>
> Signed-off-by: Masahiro Yamada <masahiroy at kernel.org>
> ---
>
>  arch/csky/kernel/vdso/Makefile | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/arch/csky/kernel/vdso/Makefile b/arch/csky/kernel/vdso/Makefile
> index 299e4e41ebc5..ddf784a62c11 100644
> --- a/arch/csky/kernel/vdso/Makefile
> +++ b/arch/csky/kernel/vdso/Makefile
> @@ -58,13 +58,3 @@ quiet_cmd_vdsold = VDSOLD  $@
>  # that contains the same symbols at the same offsets.
>  quiet_cmd_so2s = SO2S    $@
>        cmd_so2s = $(NM) -D $< | $(srctree)/$(src)/so2s.sh > $@
> -
> -# install commands for the unstripped file
> -quiet_cmd_vdso_install = INSTALL $@
> -      cmd_vdso_install = cp $(obj)/$@.dbg $(MODLIB)/vdso/$@
> -
> -vdso.so: $(obj)/vdso.so.dbg
> -       @mkdir -p $(MODLIB)/vdso
> -       $(call cmd,vdso_install)
> -
> -vdso_install: vdso.so
> --
> 2.39.2
>


-- 
Best Regards
 Guo Ren



More information about the linux-riscv mailing list