[PATCH 3/5] riscv: dts: add initial T-HEAD light SoC device tree

Guo Ren guoren at kernel.org
Sun May 21 08:37:58 PDT 2023


On Tue, May 9, 2023 at 12:44 AM Conor Dooley <conor at kernel.org> wrote:
>
> On Tue, May 09, 2023 at 12:26:10AM +0800, Jisheng Zhang wrote:
> > On Sun, May 07, 2023 at 10:35:12PM +0100, Conor Dooley wrote:
> > > On Mon, May 08, 2023 at 02:23:02AM +0800, Jisheng Zhang wrote:
> > >
> > > > +         c910_0: cpu at 0 {
> > > > +                 compatible = "thead,c910", "riscv";
> > > > +                 device_type = "cpu";
> > > > +                 riscv,isa = "rv64imafdc";
> > >
> > > Does this support more than "rv64imafdc"?
> > > I assume there's some _xtheadfoo extensions that it does support,
> > > although I am not sure how we are proceeding with those - Heiko might
> > > have a more nuanced take.
> > >
> > > > +         reset: reset-sample {
> > > > +                 compatible = "thead,reset-sample";
> > >
> > > What is a "reset-sample"?
> >
> > This node is only for opensbi. The compatible string is already in
> > opensbi. Do we also need to add dt-binding for it in linux?
>
> If it's to be included in the kernel's dts, then yes, you do need a
> dt-binding. If you remove it, then you don't :)
>
> That said, "thead,reset-sample" is a strangely named compatible, so if
> you do keep it it may end up needing a rename!
How about compatible = "thead,reset-th1520" ?

>
> Cheers,
> Conor.
>


-- 
Best Regards
 Guo Ren



More information about the linux-riscv mailing list