[PATCH v7 3/6] dt-bindings: net: snps,dwmac: Add 'ahb' reset/reset-name
Guo Samin
samin.guo at starfivetech.com
Thu Mar 16 00:36:36 PDT 2023
Re: [PATCH v7 3/6] dt-bindings: net: snps,dwmac: Add 'ahb' reset/reset-name
From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
to: Samin Guo <samin.guo at starfivetech.com>, linux-riscv at lists.infradead.org, netdev at vger.kernel.org, devicetree at vger.kernel.org, linux-kernel at vger.kernel.org
data : 2023/3/16
> On 16/03/2023 05:37, Samin Guo wrote:
>> According to:
>> stmmac_platform.c: stmmac_probe_config_dt
>> stmmac_main.c: stmmac_dvr_probe
>>
>> dwmac controller may require one (stmmaceth) or two (stmmaceth+ahb)
>> reset signals, and the maxItems of resets/reset-names is going to be 2.
>>
>> The gmac of Starfive Jh7110 SOC must have two resets.
>> it uses snps,dwmac-5.20 IP.
>>
>> Signed-off-by: Samin Guo <samin.guo at starfivetech.com>
>> Tested-by: Tommaso Merciai <tomm.merciai at gmail.com>
>
> How do you test the bindings on hardware?
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
>
> Best regards,
> Krzysztof
> Hi, Krzysztof
Thanks a lot.
Sorry, my fault. Tomaso tested gmac based on v5 version. I should only add Tested-by to the driver and dts patches, but not to dt-bindings.
I will fix it in the next version.
Best regards,
Samin
More information about the linux-riscv
mailing list