[PATCH v5 11/21] dt-bindings: clock: Add StarFive JH7110 system clock and reset generator

[Hal Feng]

On Mon, 13 Mar 2023 08:51:20 +0100, Krzysztof Kozlowski wrote:
> On 13/03/2023 03:47, Hal Feng wrote:
>> On Sat, 11 Mar 2023 08:17:00 -0600, Rob Herring wrote:
>>> On Sat, 11 Mar 2023 17:07:23 +0800, Hal Feng wrote:
>>>> From: Emil Renner Berthing <kernel at esmil.dk>
>>>>
>>>> Add bindings for the system clock and reset generator (SYSCRG) on the
>>>> JH7110 RISC-V SoC by StarFive Ltd.
>>>>
>>>> Signed-off-by: Emil Renner Berthing <kernel at esmil.dk>
>>>> Signed-off-by: Hal Feng <hal.feng at starfivetech.com>
>>>> ---
>>>>  .../clock/starfive,jh7110-syscrg.yaml         | 104 +++++++++
>>>>  MAINTAINERS                                   |   8 +-
>>>>  .../dt-bindings/clock/starfive,jh7110-crg.h   | 203 ++++++++++++++++++
>>>>  .../dt-bindings/reset/starfive,jh7110-crg.h   | 142 ++++++++++++
>>>>  4 files changed, 454 insertions(+), 3 deletions(-)
>>>>  create mode 100644 Documentation/devicetree/bindings/clock/starfive,jh7110-syscrg.yaml
>>>>  create mode 100644 include/dt-bindings/clock/starfive,jh7110-crg.h
>>>>  create mode 100644 include/dt-bindings/reset/starfive,jh7110-crg.h
>>>>
>>>
>>>
>>> Please add Acked-by/Reviewed-by tags when posting new versions. However,
>>> there's no need to repost patches *only* to add the tags. The upstream
>>> maintainer will do that for acks received on the version they apply.
>>>
>>> If a tag was not added on purpose, please state why and what changed.
>>>
>>> Missing tags:
>>>
>>> Reviewed-by: Rob Herring <robh at kernel.org>
>> 
>> This patch has been changed a lot and I am not sure whether it's still
>> the one you want. So I removed the Reviewed-by tag.
> 
> Then mention it in changelog, just like Rob asked:
> "If a tag was not added on purpose, please state why and what changed."
> I don't see any explanation in the changelog about it.

So sorry for missing that. Thank you for your suggestions.

Best regards,
Hal