[PATCH] RISC-V: Fix up some vector state related build failures

Conor Dooley conor.dooley at microchip.com
Tue Jun 20 00:33:57 PDT 2023


On Mon, Jun 19, 2023 at 10:21:01AM -0700, Palmer Dabbelt wrote:
> I get a few build failures along the lines of
> 
> ./arch/riscv/include/uapi/asm/sigcontext.h:19:36: error: field ‘v_state’ has incomplete type
>    19 |         struct __riscv_v_ext_state v_state;
>       |                                    ^~~~~~~
> ./arch/riscv/include/uapi/asm/sigcontext.h:32:49: error: field ‘sc_extdesc’ has incomplete type
>    32 |                 struct __riscv_extra_ext_header sc_extdesc;
> 
> The V structures in question are defined for !assembly, so let's just do
> so for the others.
> 
> Fixes: 8ee0b41898fa ("riscv: signal: Add sigcontext save/restore for vector")
> Signed-off-by: Palmer Dabbelt <palmer at rivosinc.com>

Not the first time you've caught this sort of problem in headers, is
there a particular build that catches these?

Reviewed-by: Conor Dooley <conor.dooley at microchip.com>

Cheers,
Conor.

> ---
>  arch/riscv/include/uapi/asm/sigcontext.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/riscv/include/uapi/asm/sigcontext.h b/arch/riscv/include/uapi/asm/sigcontext.h
> index 8b8a8541673a..8c8712aa9551 100644
> --- a/arch/riscv/include/uapi/asm/sigcontext.h
> +++ b/arch/riscv/include/uapi/asm/sigcontext.h
> @@ -15,6 +15,8 @@
>  /* The size of END signal context header. */
>  #define END_HDR_SIZE	0x0
>  
> +#ifndef __ASSEMBLY__
> +
>  struct __sc_riscv_v_state {
>  	struct __riscv_v_ext_state v_state;
>  } __attribute__((aligned(16)));
> @@ -33,4 +35,6 @@ struct sigcontext {
>  	};
>  };
>  
> +#endif /*!__ASSEMBLY__*/
> +
>  #endif /* _UAPI_ASM_RISCV_SIGCONTEXT_H */
> -- 
> 2.40.1
> 
> 
> _______________________________________________
> linux-riscv mailing list
> linux-riscv at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20230620/d0ee7b82/attachment.sig>


More information about the linux-riscv mailing list