[PATCH v3] gpio: ath79: Add missing check for platform_get_irq
andy.shevchenko at gmail.com
andy.shevchenko at gmail.com
Tue Jun 6 02:28:17 PDT 2023
Tue, Jun 06, 2023 at 11:18:41AM +0800, Jiasheng Jiang kirjoitti:
Is this v4?
> Add the missing check for platform_get_irq() and return error
> if it fails.
> The returned error code will be dealed with in
> module_platform_driver(ath79_gpio_driver) and the driver will not
> be registered.
No, this functional change and has not to be for the fixes unless _this_ is the
regression you are fixing. Did the driver work before at some point as after
this change?
Otherwise you have to _justify_ that this functional change won't break
existing setups (with broked IRQ in Device Tree, for example).
--
With Best Regards,
Andy Shevchenko
More information about the linux-riscv
mailing list