[PATCH -next] i2c: microchip-corei2c: clean up redundant dev_err_probe()

Conor Dooley conor.dooley at microchip.com
Fri Jul 28 01:44:30 PDT 2023


On Fri, Jul 28, 2023 at 04:31:37PM +0800, Chen Jiahao wrote:
> Referring to platform_get_irq()'s definition, the return value has
> already been checked, error message also been printed via
> dev_err_probe() if ret < 0. Calling dev_err_probe() one more time
> outside platform_get_irq() is obviously redundant.
> 
> Furthermore, platform_get_irq() will never return irq equals 0,
> removing spi->irq == 0 checking to clean it up.
> 
> Signed-off-by: Chen Jiahao <chenjiahao16 at huawei.com>

Reviewed-by: Conor Dooley <conor.dooley at microchip.com>

Thanks,
Conor.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20230728/940220f0/attachment.sig>


More information about the linux-riscv mailing list