[PATCH 2/2] dt-bindings: dma: cleanup examples - indentation, lowercase hex

Krzysztof Kozlowski krzysztof.kozlowski at linaro.org
Mon Jan 23 23:52:35 PST 2023


On 23/01/2023 21:20, Rob Herring wrote:
> On Wed, Jan 18, 2023 at 07:01:44PM +0100, Krzysztof Kozlowski wrote:
>> Cleanup examples:
>>  - use 4-space indentation (for cases when it is neither 4 not 2 space),
>>  - use lowercase hex.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
>> ---
>>  .../bindings/dma/snps,dw-axi-dmac.yaml        | 36 +++++++++----------
>>  .../bindings/dma/stericsson,dma40.yaml        |  4 +--
>>  2 files changed, 20 insertions(+), 20 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>> index 2bedab1f74e0..d34d0fa62ab5 100644
>> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>> @@ -113,21 +113,21 @@ additionalProperties: false
>>  
>>  examples:
>>    - |
>> -     #include <dt-bindings/interrupt-controller/arm-gic.h>
>> -     #include <dt-bindings/interrupt-controller/irq.h>
>> -     /* example with snps,dw-axi-dmac */
>> -     dmac: dma-controller at 80000 {
>> -         compatible = "snps,axi-dma-1.01a";
>> -         reg = <0x80000 0x400>;
>> -         clocks = <&core_clk>, <&cfgr_clk>;
>> -         clock-names = "core-clk", "cfgr-clk";
>> -         interrupt-parent = <&intc>;
>> -         interrupts = <27>;
>> -         #dma-cells = <1>;
>> -         dma-channels = <4>;
>> -         snps,dma-masters = <2>;
>> -         snps,data-width = <3>;
>> -         snps,block-size = <4096 4096 4096 4096>;
>> -         snps,priority = <0 1 2 3>;
>> -         snps,axi-max-burst-len = <16>;
>> -     };
>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +    #include <dt-bindings/interrupt-controller/irq.h>
>> +    /* example with snps,dw-axi-dmac */
>> +    dmac: dma-controller at 80000 {
> 
> Drop unused labels while you are here.

Ack

> 
>> +        compatible = "snps,axi-dma-1.01a";
>> +        reg = <0x80000 0x400>;
>> +        clocks = <&core_clk>, <&cfgr_clk>;
>> +        clock-names = "core-clk", "cfgr-clk";
>> +        interrupt-parent = <&intc>;
>> +        interrupts = <27>;
>> +        #dma-cells = <1>;
>> +        dma-channels = <4>;
>> +        snps,dma-masters = <2>;
>> +        snps,data-width = <3>;
>> +        snps,block-size = <4096 4096 4096 4096>;
>> +        snps,priority = <0 1 2 3>;
>> +        snps,axi-max-burst-len = <16>;
>> +    };
>> diff --git a/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml b/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml
>> index 664ee61a00d8..57395a810719 100644
>> --- a/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml
>> +++ b/Documentation/devicetree/bindings/dma/stericsson,dma40.yaml
>> @@ -147,9 +147,9 @@ examples:
>>      #include <dt-bindings/interrupt-controller/irq.h>
>>      #include <dt-bindings/interrupt-controller/arm-gic.h>
>>      #include <dt-bindings/mfd/dbx500-prcmu.h>
>> -    dma-controller at 801C0000 {
>> +    dma-controller at 801c0000 {
>>        compatible = "stericsson,db8500-dma40", "stericsson,dma40";
>> -      reg = <0x801C0000 0x1000>, <0x40010000 0x800>;
>> +      reg = <0x801c0000 0x1000>, <0x40010000 0x800>;
>>        reg-names = "base", "lcpa";
>>        interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
>>        #dma-cells = <3>;
> 
> Indentation?

Ack

Best regards,
Krzysztof




More information about the linux-riscv mailing list