[PATCH 12/20] clk: microchip: mpfs: remove MODULE_LICENSE in non-modules
Conor Dooley
conor at kernel.org
Tue Feb 28 11:19:32 PST 2023
On Tue, Feb 28, 2023 at 01:02:07PM +0000, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock at oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof at kernel.org>
> Cc: Luis Chamberlain <mcgrof at kernel.org>
> Cc: linux-modules at vger.kernel.org
> Cc: linux-kernel at vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi at fujitsu.com>
> Cc: Conor Dooley <conor.dooley at microchip.com>
> Cc: Daire McNamara <daire.mcnamara at microchip.com>
> Cc: Michael Turquette <mturquette at baylibre.com>
> Cc: Stephen Boyd <sboyd at kernel.org>
> Cc: linux-riscv at lists.infradead.org
> Cc: linux-clk at vger.kernel.org
> ---
> drivers/clk/microchip/clk-mpfs.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clk/microchip/clk-mpfs.c b/drivers/clk/microchip/clk-mpfs.c
> index 4f0a19db7ed74..d85b345f4c08d 100644
> --- a/drivers/clk/microchip/clk-mpfs.c
> +++ b/drivers/clk/microchip/clk-mpfs.c
> @@ -513,4 +513,3 @@ MODULE_DESCRIPTION("Microchip PolarFire SoC Clock Driver");
> MODULE_AUTHOR("Padmarao Begari <padmarao.begari at microchip.com>");
> MODULE_AUTHOR("Daire McNamara <daire.mcnamara at microchip.com>");
> MODULE_AUTHOR("Conor Dooley <conor.dooley at microchip.com>");
> -MODULE_LICENSE("GPL");
Reviewed-by: Conor Dooley <conor.dooley at microchip.com>
I'll take this via the microchip/at91 clock tree after v6.3-rc1 has been
released.
Thanks,
Conor.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20230228/8aedb844/attachment.sig>
More information about the linux-riscv
mailing list