[PATCH bpf-next] riscv, bpf: fix patch_text implicit declaration
Pu Lehui
pulehui at huawei.com
Sun Feb 26 22:51:47 PST 2023
On 2023/2/27 12:02, Randy Dunlap wrote:
> bpf_jit_comp64.c uses patch_text(), so add it to a local header file
> to prevent the build error:
>
> ../arch/riscv/net/bpf_jit_comp64.c: In function 'bpf_arch_text_poke':
> ../arch/riscv/net/bpf_jit_comp64.c:691:23: error: implicit declaration of function 'patch_text'; did you mean 'path_get'? [-Werror=implicit-function-declaration]
> 691 | ret = patch_text(ip, new_insns, ninsns);
> | ^~~~~~~~~~
>
> Fixes: 596f2e6f9cf4 ("riscv, bpf: Add bpf_arch_text_poke support for RV64")
> Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
> Reported-by: kernel test robot <lkp at intel.com>
> Link: https://lore.kernel.org/r/202302271000.Aj4nMXbZ-lkp@intel.com
> Cc: Pu Lehui <pulehui at huawei.com>
> Cc: Luke Nelson <luke.r.nels at gmail.com>
> Cc: Xi Wang <xi.wang at gmail.com>
> Cc: bpf at vger.kernel.org
> Cc: Alexei Starovoitov <ast at kernel.org>
> Cc: Daniel Borkmann <daniel at iogearbox.net>
> Cc: John Fastabend <john.fastabend at gmail.com>
> Cc: Andrii Nakryiko <andrii at kernel.org>
> Cc: Paul Walmsley <paul.walmsley at sifive.com>
> Cc: Palmer Dabbelt <palmer at dabbelt.com>
> Cc: Albert Ou <aou at eecs.berkeley.edu>
> Cc: "Björn Töpel" <bjorn at kernel.org>
> Cc: linux-riscv at lists.infradead.org
> ---
> What is the proper path to have this merged soon to stop build
> errors?
>
> arch/riscv/net/bpf_jit.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/arch/riscv/net/bpf_jit.h b/arch/riscv/net/bpf_jit.h
> --- a/arch/riscv/net/bpf_jit.h
> +++ b/arch/riscv/net/bpf_jit.h
> @@ -12,6 +12,7 @@
> #include <linux/bpf.h>
> #include <linux/filter.h>
> #include <asm/cacheflush.h>
> +#include <asm/patch.h>
>
Thanks Randy. Since patch_text is only used in riscv64 at present, I
think it is appropriate to add it to arch/riscv/net/bpf_jit_comp64.c
> static inline bool rvc_enabled(void)
> {
More information about the linux-riscv
mailing list