[PATCH v1] RISC-V: add a spin_shadow_stack declaration

Conor Dooley conor at kernel.org
Sat Feb 11 02:16:18 PST 2023


On Sat, Feb 11, 2023 at 01:04:43PM +0800, Guo Ren wrote:
> On Sat, Feb 11, 2023 at 2:59 AM Conor Dooley <conor at kernel.org> wrote:
> >
> > From: Conor Dooley <conor.dooley at microchip.com>
> >
> > The patchwork automation reported a sparse complaint that
> > spin_shadow_stack was not declared and should be static:
> > ../arch/riscv/kernel/traps.c:335:15: warning: symbol 'spin_shadow_stack' was not declared. Should it be static?
> >
> > However, this is used in entry.S and therefore shouldn't be static.
> > The same applies to the shadow_stack that this pseudo spinlock is
> > trying to protect, so do like its charge and add a declaration to
> > thread_info.h
> >
> > Signed-off-by: Conor Dooley <conor.dooley at microchip.com>
> > ---
> > Applies on top of Guo Ren's generic entry series.
> It's needn't on top of my generic entry series. It's the separate patch for:

I didn't mean I was "blaming" your series for it's introduction, I meant
that I created the patch using your series as a base to avoid any
potential for conflicts.

> Fixes: 7e1864332fbc ("riscv: fix race when vmap stack overflow")

Wasn't sure if this warranted one, but you're probably right to add it.

> Reviewed-by: Guo Ren <guoren at kernel.org>

Thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20230211/ee4946a6/attachment.sig>


More information about the linux-riscv mailing list