[PATCH] riscv: hwcap: Don't alphabetize ISA extension IDs

[Conor Dooley]

On Thu, Feb 09, 2023 at 01:36:36PM +0100, Andrew Jones wrote:
> While the comment above the ISA extension ID definitions says
> "Entries are sorted alphabetically.", this stopped being good
> advice with commit d8a3d8a75206 ("riscv: hwcap: make ISA extension
> ids can be used in asm"), as we now use macros instead of enums.

Yes, this ideally would have been removed by the commit doing the swap
over, but as both were in-flight simultaneously it was missed.
I intended going looking to see if this was dangling but clearly forgot.

> Reshuffling defines is error-prone, so, since they don't need to be
> in any particular order, change the advice to just adding new
> extensions at the bottom.

This aligns with what we "agreed" on Jisheng's patchset was the sanest
way to handle this.

> Also, take the opportunity to change
> spaces to tabs, merge three comments into one, and move the base
> and max defines into more logical locations wrt the ID definitions.

Sure, why not...

> Signed-off-by: Andrew Jones <ajones at ventanamicro.com>

Reviewed-by: Conor Dooley <conor.dooley at microchip.com>

Thanks for fixing this up Drew!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20230209/787916c7/attachment.sig>