[PATCH v1 1/8] dt-bindings: pinctrl: Add thead,th1520-pinctrl bindings

[Linus Walleij]

On Thu, Dec 21, 2023 at 1:28 PM Emil Renner Berthing
<emil.renner.berthing at canonical.com> wrote:
> Linus Walleij wrote:
> > On Sat, Dec 16, 2023 at 2:57 PM Emil Renner Berthing
> > <emil.renner.berthing at canonical.com> wrote:
> >
> > > > > +          thead,strong-pull-up:
> > > > > +            oneOf:
> > > > > +              - type: boolean
> > > > > +              - $ref: /schemas/types.yaml#/definitions/uint32
> > > > > +                enum: [ 0, 2100 ]
> > > > > +            description: Enable or disable strong 2.1kOhm pull-up.
> > > >
> > > > bias-pull-up can already specify the strength in Ohms.
> > >
> > > The strong pull up is a separate bit that can be enabled independently from the
> > > regular pull-up/down, so in theory you could enable both the regular pull-up
> > > and the strong pull-up at the same time, or even the regular poll-down and the
> > > strong pull-up which is probably not advised.
> >
> > bias-pull-up; <- Just regular pulling up the ordinary
> > bias-pull-up = <100>; <- Same thing if the ordinary is 100 Ohm (figure out what
> >   resistance it actually is....)
> > bias-pull-up = <21000000>; <- strong pull up
> > bias-pull-up = <21000100>; <- both at the same time
>
> Hmm.. the two pull-ups combined would be a stronger pull-up, eg. lower
> resistance, right? So you'd need to calculate it using
> https://en.wikipedia.org/wiki/Series_and_parallel_circuits#Resistance_units_2

Yeah hehe elementary electronics beats me, of course it is in parallel.

> The problem is that the documentation doesn't actually mention what will happen
> if you combine the strong pull-up with the regular bias.

So why even allow it then?

Do the people designing boards using this have better documentation than what
you have? Then either get that documentation or just don't give them
too much rope.

Yours,
Linus Walleij