[PATCH v1] riscv: dts: starfive: move timebase-frequency to .dtsi

[JeeHeng Sia]

> -----Original Message-----
> From: Conor Dooley <conor at kernel.org>
> Sent: Friday, December 1, 2023 12:11 AM
> To: linux-riscv at lists.infradead.org
> Cc: conor at kernel.org; Conor Dooley <conor.dooley at microchip.com>; Emil Renner Berthing <kernel at esmil.dk>; Rob Herring
> <robh+dt at kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt at linaro.org>; Paul Walmsley <paul.walmsley at sifive.com>;
> Palmer Dabbelt <palmer at dabbelt.com>; devicetree at vger.kernel.org; linux-kernel at vger.kernel.org; Walker Chen
> <walker.chen at starfivetech.com>; JeeHeng Sia <jeeheng.sia at starfivetech.com>; Leyfoon Tan <leyfoon.tan at starfivetech.com>
> Subject: [PATCH v1] riscv: dts: starfive: move timebase-frequency to .dtsi
> 
> From: Conor Dooley <conor.dooley at microchip.com>
> 
> Properties fixed by the SoC should be defined in the $soc.dtsi, and the
> timebase-frequency is not sourced directly from an off-chip oscillator.
> 
> Signed-off-by: Conor Dooley <conor.dooley at microchip.com>
> ---
> I actually have no idea whether this is true or not, I asked on the
> jh8100 series but only got an answer for that SoC and not the existing
> ones. I'm hoping that a patch envokes more of a reaction!
I believe it is controlled by the internal clock, but I will let Walker
have the final say.
> 
> CC: Emil Renner Berthing <kernel at esmil.dk>
> CC: Conor Dooley <conor at kernel.org>
> CC: Rob Herring <robh+dt at kernel.org>
> CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt at linaro.org>
> CC: Paul Walmsley <paul.walmsley at sifive.com>
> CC: Palmer Dabbelt <palmer at dabbelt.com>
> CC: linux-riscv at lists.infradead.org
> CC: devicetree at vger.kernel.org
> CC: linux-kernel at vger.kernel.org
> CC: Walker Chen <walker.chen at starfivetech.com>
> CC: JeeHeng Sia <jeeheng.sia at starfivetech.com>
> CC: Leyfoon Tan <leyfoon.tan at starfivetech.com>
> ---
>  arch/riscv/boot/dts/starfive/jh7100-common.dtsi               | 4 ----
>  arch/riscv/boot/dts/starfive/jh7100.dtsi                      | 1 +
>  .../riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi | 4 ----
>  arch/riscv/boot/dts/starfive/jh7110.dtsi                      | 1 +
>  4 files changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/riscv/boot/dts/starfive/jh7100-common.dtsi b/arch/riscv/boot/dts/starfive/jh7100-common.dtsi
> index b93ce351a90f..214f27083d7b 100644
> --- a/arch/riscv/boot/dts/starfive/jh7100-common.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7100-common.dtsi
> @@ -19,10 +19,6 @@ chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
> 
> -	cpus {
> -		timebase-frequency = <6250000>;
> -	};
> -
>  	memory at 80000000 {
>  		device_type = "memory";
>  		reg = <0x0 0x80000000 0x2 0x0>;
> diff --git a/arch/riscv/boot/dts/starfive/jh7100.dtsi b/arch/riscv/boot/dts/starfive/jh7100.dtsi
> index e68cafe7545f..c50b32424721 100644
> --- a/arch/riscv/boot/dts/starfive/jh7100.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7100.dtsi
> @@ -16,6 +16,7 @@ / {
>  	cpus {
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> +		timebase-frequency = <6250000>;
> 
>  		U74_0: cpu at 0 {
>  			compatible = "sifive,u74-mc", "riscv";
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-
> 2.dtsi
> index b89e9791efa7..7873c7ffde4d 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
> @@ -26,10 +26,6 @@ chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
> 
> -	cpus {
> -		timebase-frequency = <4000000>;
> -	};
> -
>  	memory at 40000000 {
>  		device_type = "memory";
>  		reg = <0x0 0x40000000 0x1 0x0>;
> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> index 45213cdf50dc..ee7d4bb1f537 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
> @@ -18,6 +18,7 @@ / {
>  	cpus {
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> +		timebase-frequency = <4000000>;
> 
>  		S7_0: cpu at 0 {
>  			compatible = "sifive,s7", "riscv";
> --
> 2.39.2