[PATCH] drivers/perf: Risc-V: Update platform specific firmware event handling

Conor Dooley conor at kernel.org
Tue Aug 15 06:14:10 PDT 2023


On Mon, Aug 14, 2023 at 10:01:34AM +0530, Mayuresh Chitale wrote:
> +			/*
> +			 * For Risc-V platform specific firmware events

This is a nit, but it my OCD is triggered every time I read it - please
don't invent another style of writing the name of the architecture, both
here and in the commit message. If you respin for some other reason,
could you please change these to one of the established styles?

Thanks,
Conor.

> +			 * Event code - 0xFFFF
> +			 * Event data - raw event encoding
> +			 */
> +			ret = SBI_PMU_EVENT_TYPE_FW << 16 | RISCV_PLAT_FW_EVENT;
>  			*econfig = raw_config_val;
> +			break;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-riscv/attachments/20230815/99ac8e1f/attachment.sig>


More information about the linux-riscv mailing list