[PATCH v2] riscv: mm: fix 2 instances of -Wmissing-variable-declarations
Palmer Dabbelt
palmer at rivosinc.com
Thu Aug 10 12:44:03 PDT 2023
On Tue, 08 Aug 2023 09:35:00 -0700, Nick Desaulniers wrote:
> I'm looking to enable -Wmissing-variable-declarations behind W=1. 0day
> bot spotted the following instance in ARCH=riscv builds:
>
> arch/riscv/mm/init.c:276:7: warning: no previous extern declaration
> for non-static variable 'trampoline_pg_dir'
> [-Wmissing-variable-declarations]
> 276 | pgd_t trampoline_pg_dir[PTRS_PER_PGD] __page_aligned_bss;
> | ^
> arch/riscv/mm/init.c:276:1: note: declare 'static' if the variable is
> not intended to be used outside of this translation unit
> 276 | pgd_t trampoline_pg_dir[PTRS_PER_PGD] __page_aligned_bss;
> | ^
> arch/riscv/mm/init.c:279:7: warning: no previous extern declaration
> for non-static variable 'early_pg_dir'
> [-Wmissing-variable-declarations]
> 279 | pgd_t early_pg_dir[PTRS_PER_PGD] __initdata __aligned(PAGE_SIZE);
> | ^
> arch/riscv/mm/init.c:279:1: note: declare 'static' if the variable is
> not intended to be used outside of this translation unit
> 279 | pgd_t early_pg_dir[PTRS_PER_PGD] __initdata __aligned(PAGE_SIZE);
> | ^
>
> [...]
Applied, thanks!
[1/1] riscv: mm: fix 2 instances of -Wmissing-variable-declarations
https://git.kernel.org/palmer/c/d2402048bc8a
Best regards,
--
Palmer Dabbelt <palmer at rivosinc.com>
More information about the linux-riscv
mailing list