[PATCH v2] RISC-V: cpu: refactor deprecated strncpy

Palmer Dabbelt palmer at dabbelt.com
Wed Aug 2 13:41:52 PDT 2023


On Wed, 02 Aug 2023 13:36:03 PDT (-0700), keescook at chromium.org wrote:
> On Wed, Aug 02, 2023 at 12:21:58AM +0000, Justin Stitt wrote:
>> `strncpy` is deprecated for use on NUL-terminated destination strings [1].
>>
>> Favor not copying strings onto stack and instead use strings directly.
>> This avoids hard-coding sizes and buffer lengths all together.
>>
>> Link: https://github.com/KSPP/linux/issues/90
>> Cc: linux-hardening at vger.kernel.org
>> Suggested-by: Kees Cook <keescook at chromium.org>
>> Signed-off-by: Justin Stitt <justinstitt at google.com>
>
> I like it! ;)
>
> Reviewed-by: Kees Cook <keescook at chromium.org>

Thanks, I just queue it up for fixes (might take a bit to build test, 
I'm a bit backed up).

Reviewed-by: Palmer Dabbelt <palmer at rivosinc.com>
Acked-by: Palmer Dabbelt <palmer at rivosinc.com>

If you wanted to take it for some hardening thing, though -- otherwise 
it'll likely end up on my fixes later today.



More information about the linux-riscv mailing list