[RFC 07/27] riscv: replace SOC_STARFIVE with ARCH_STARFIVE

Conor Dooley conor at kernel.org
Fri Sep 23 12:22:47 PDT 2022


On 23/09/2022 20:20, Heiko Stuebner wrote:
> Am Freitag, 23. September 2022, 21:14:58 CEST schrieb Conor Dooley:
>> On Fri, Sep 23, 2022 at 09:09:03PM +0200, Heiko Stuebner wrote:
>>> Hi Conor,
>>>
>>> Am Freitag, 23. September 2022, 20:55:46 CEST schrieb Conor Dooley:
>>>> From: Conor Dooley <conor.dooley at microchip.com>
>>>>
>>>> As discussed at LPC, the SOC_ symbols are being converted to ARCH_
>>>> for the sake of consistency between "incumbent" vendors and those who
>>>> have a legacy from other archs.
>>>>
>>>> Convert SOC_STARFIVE to ARCH_STARFIVE across arch/riscv
>>>>
>>>> Signed-off-by: Conor Dooley <conor.dooley at microchip.com>
>>>> ---
>>>>  arch/riscv/Kconfig.socs               | 2 +-
>>>>  arch/riscv/boot/dts/starfive/Makefile | 2 +-
>>>>  arch/riscv/configs/defconfig          | 2 +-
>>>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
>>>> index c4c7add1516f..910697baf097 100644
>>>> --- a/arch/riscv/Kconfig.socs
>>>> +++ b/arch/riscv/Kconfig.socs
>>>> @@ -17,7 +17,7 @@ config SOC_SIFIVE
>>>>  	help
>>>>  	  This enables support for SiFive SoC platform hardware.
>>>>  
>>>> -config SOC_STARFIVE
>>>> +config ARCH_STARFIVE
>>>
>>> doesn't this create a bisection issue?
>>
>> Yeah, I thought of that midway through and then promptly forgot about
>> it... I'll sort it out for v1.
> 
> It's of course the same for sifive and probably more.
> 
> ARCH_MICROCHIP was pre-existing in your series, so that transistion
> goes way smoother - though I haven't been able to find where that
> symbol actually got added :-) .
> 
> I.e. in Palmers next branchs the symbol is still SOC_MICROCHIP_POLARFIRE

Ah for god's sake, I gave the wrong hash to format-patch lol.

I didn't check carefully to be honest as I wasn't too concerned about
the content and more about how I would break the series up!

I am glad I said RFC...




More information about the linux-riscv mailing list