[PATCH v2 3/3] tty: serial: use DEFINE_UART_PORT_TX_HELPER_LIMITED()

Ilpo Järvinen ilpo.jarvinen at linux.intel.com
Fri Sep 2 07:56:40 PDT 2022


On Thu, 1 Sep 2022, Jiri Slaby wrote:

> DEFINE_UART_PORT_TX_HELPER_LIMITED() is a new helper to send characters
> to the device. Use it in these drivers.
> 
> mux.c also needs to define tx_done(). But I'm not sure if the driver
> really wants to wait for all the characters to dismiss from the HW fifo
> at this code point. Hence I marked this as FIXME.

Indeed, it seems odd.

This change looked good to me but I'll give my rev-by only after seeing 
the next version.

-- 
 i.


> Signed-off-by: Jiri Slaby <jslaby at suse.cz>
> Cc: Russell King <linux at armlinux.org.uk>
> Cc: Florian Fainelli <f.fainelli at gmail.com>
> Cc: bcm-kernel-feedback-list at broadcom.com
> Cc: "Pali Rohár" <pali at kernel.org>
> Cc: Kevin Cernekee <cernekee at gmail.com>
> Cc: Palmer Dabbelt <palmer at dabbelt.com>
> Cc: Paul Walmsley <paul.walmsley at sifive.com>
> Cc: Orson Zhai <orsonzhai at gmail.com>
> Cc: Baolin Wang <baolin.wang7 at gmail.com>
> Cc: Chunyan Zhang <zhang.lyra at gmail.com>
> Cc: Patrice Chotard <patrice.chotard at foss.st.com>
> Cc: linux-riscv at lists.infradead.org


More information about the linux-riscv mailing list