[PATCH v4 2/7] asm-generic: qspinlock: Indicate the use of mixed-size atomics

Arnd Bergmann arnd at arndb.de
Thu May 5 04:05:11 PDT 2022


On Wed, May 4, 2022 at 2:02 PM Heiko Stübner <heiko at sntech.de> wrote:
> > index d74b13825501..95be3f3c28b5 100644
> > --- a/include/asm-generic/qspinlock.h
> > +++ b/include/asm-generic/qspinlock.h
> > @@ -2,6 +2,37 @@
> >  /*
> >   * Queued spinlock
> >   *
> > + * A 'generic' spinlock implementation that is based on MCS locks. An
>
> _For_ an architecture that's ... ?
>
> > + * architecture that's looking for a 'generic' spinlock, please first consider
> > + * ticket-lock.h and only come looking here when you've considered all the
> > + * constraints below and can show your hardware does actually perform better
> > + * with qspinlock.
> > + *
> > + *
>
> double empty line is probably not necessary
>

I've applied the series to the asm-generic tree now, and edited both the above
as you suggested in the process, to save Palmer the v5.

         Arnd



More information about the linux-riscv mailing list