[PATCH v2] soc: sifive: (sifive_l2_cache) Add missing of_node_put()

Conor.Dooley at microchip.com Conor.Dooley at microchip.com
Wed Jun 15 23:26:17 PDT 2022


On 16/06/2022 06:54, Liang He wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> At 2022-06-16 12:49:15, "Liang He" <windhl at 126.com> wrote:
>> In sifive_l2_init(), of_find_matching_node() will return a node pointer
>> with refcount incremented. We should use of_node_put() in each fail path
>> or when it is not used anymore.
>>
>> Reported-by: kernel test robot <lkp at intel.com>
>>
>> Signed-off-by: Liang He <windhl at 126.com>
>> ---
> 
> 
> Sorry, please ignore this version as it still has a bug.  I will have a strict check and compile the code before my next commit.

While you're at it - drop the Reported-by too.
You only need to include that if LKP found a problem with
a patch that's been applied already. If it's on something
in progress, just fix what it pointed out & resend.

Thanks,
Conor.



More information about the linux-riscv mailing list