[PATCH] spi: microchip-core: fix passing zero to PTR_ERR warning
Conor.Dooley at microchip.com
Conor.Dooley at microchip.com
Wed Jun 15 04:57:37 PDT 2022
On 15/06/2022 12:40, Mark Brown wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Wed, Jun 15, 2022 at 12:30:22PM +0100, Conor Dooley wrote:
>
>> - ret = PTR_ERR(spi->clk);
>> + ret = !spi->clk ? -ENXIO : PTR_ERR(spi->clk);
>
> I think you're looking for PTR_ERR_OR_ZERO() here?
Maybe I don't understand, so let me explain what I think you're
suggesting & maybe you can correct me:
> - ret = PTR_ERR(spi->clk);
> + ret = PTR_ERR_OR_ZERO(spi->clk);
But if spi->clk is NULL, this will return 0 from the probe
rather than returning an error?
If that's not what you meant, lmk
Thanks,
Conor.
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
More information about the linux-riscv
mailing list