[PATCH V6 2/2] irqchip/sifive-plic: Fixup thead, c900-plic dt parse in opensbi

Marc Zyngier maz at kernel.org
Sun Jan 30 06:59:13 PST 2022


On Sun, 30 Jan 2022 13:09:21 +0000,
Guo Ren <guoren at kernel.org> wrote:
> 
> On Sun, Jan 30, 2022 at 6:28 PM Marc Zyngier <maz at kernel.org> wrote:
> >
> > On Sun, 30 Jan 2022 04:39:34 +0000,
> > Guo Ren <guoren at kernel.org> wrote:
> > >
> > > > +IRQCHIP_DECLARE(thead_c900_plic, "thead,c900-plic", plic_init);
> > > I think we should give clear info in /proc/interrupts. I hope we could
> > > keep thead_plic_init.
> >
> > Why? There is no material difference at the driver level, and
> > /proc/interrupts won't be the target of a branding exercise (which
> > this series seems to be all about).
> It's not a branding exercise, the series just correct the broken code
> & incorrect /proc/interrupts display.

There is *nothing* incorrect in /proc/interrupt. If anything, changing
the string *is* an ABI change, for no good reason.

	M.

-- 
Without deviation from the norm, progress is not possible.



More information about the linux-riscv mailing list