[PATCH] riscv: fix oops caused by irq on/off tracer
kernel test robot
lkp at intel.com
Fri Jan 28 13:03:59 PST 2022
Hi Changbin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.17-rc1 next-20220128]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Changbin-Du/riscv-fix-oops-caused-by-irq-on-off-tracer/20220128-233136
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 145d9b498fc827b79c1260b4caa29a8e59d4c2b9
config: riscv-buildonly-randconfig-r003-20220127 (https://download.01.org/0day-ci/archive/20220129/202201290448.aKF0qISQ-lkp@intel.com/config)
compiler: riscv32-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/d3adbc803a5b4d49e649489eec980048266e2a72
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Changbin-Du/riscv-fix-oops-caused-by-irq-on-off-tracer/20220128-233136
git checkout d3adbc803a5b4d49e649489eec980048266e2a72
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=riscv SHELL=/bin/bash arch/riscv/kernel/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>
All warnings (new ones prefixed by >>):
>> arch/riscv/kernel/trace_irq.c:14:6: warning: no previous prototype for '__trace_hardirqs_on' [-Wmissing-prototypes]
14 | void __trace_hardirqs_on(void)
| ^~~~~~~~~~~~~~~~~~~
>> arch/riscv/kernel/trace_irq.c:20:6: warning: no previous prototype for '__trace_hardirqs_off' [-Wmissing-prototypes]
20 | void __trace_hardirqs_off(void)
| ^~~~~~~~~~~~~~~~~~~~
--
>> arch/riscv/kernel/trace_irq.c:10: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* trace_hardirqs_on/off requires at least two parent call frames. Here we add
vim +/__trace_hardirqs_on +14 arch/riscv/kernel/trace_irq.c
8
9 /**
> 10 * trace_hardirqs_on/off requires at least two parent call frames. Here we add
11 * one extra level so they can be safely called by low level entry code.
12 */
13
> 14 void __trace_hardirqs_on(void)
15 {
16 trace_hardirqs_on();
17 }
18 NOKPROBE_SYMBOL(__trace_hardirqs_on);
19
> 20 void __trace_hardirqs_off(void)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
More information about the linux-riscv
mailing list