[PATCH] riscv: add correct as-options for assembly in modules

Bin Meng bmeng.cn at gmail.com
Mon Jan 10 23:41:38 PST 2022


On Thu, Dec 9, 2021 at 3:26 AM Ben Dooks <ben.dooks at codethink.co.uk> wrote:
>
> When trying to load modules built for riscv which include assembly
> the kernel loader errors with "unexpected relocation type 'R_RISCV_ALIGN'"
> due to R_RISCV_ALIGN relocations being generated by the assembler.
>
> In commit 7a8e7da42250138 ("RISC-V: Fixes to module loading") the
> CFLAGS have -mno-relax added. This however does not get applied to
> KBUILD_AFLAGS_MODULE so when a module builds a .S file, the -mno-relax
> is not passed and the above error is seen. Fix it by adding the flags
> '-Wa,-mno-relax' to KBUILD_AFLAGS_MODULE.
>
> This may have been fixed in gcc, in:
>  https://github.com/gcc-mirror/gcc/commit/3b0a7d624e64eeb81e4d5e8c62c46d86ef521857
>
> Signed-off-by: Ben Dooks <ben.dooks at codethink.co.uk>
> --
> Changes since v1:
> - added Bin Meng's review of the original patch

Looks like you forgot to include the RB tag? :)

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>

> ---
>  arch/riscv/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>

Regards,
Bin



More information about the linux-riscv mailing list