[PATCH v3 RESEND] clk: sifive: Fix W=1 kernel build warning

Zong Li zong.li at sifive.com
Sun Jan 9 17:52:27 PST 2022


On Sat, Jan 8, 2022 at 8:45 AM Stephen Boyd <sboyd at kernel.org> wrote:
>
> Quoting Zong Li (2022-01-07 01:07:15)
> > This commit reverts commit 487dc7bb6a0c ("clk: sifive: fu540-prci:
> > Declare static const variable 'prci_clk_fu540' where it's used").
> > For fixing W=1 kernel build warning(s) about ‘prci_clk_fu540’ defined
> > but not used [-Wunused-const-variable=], the problem is that the C file
> > of fu540 and fu740 doesn't use these variables, but they includes the
> > header files. We could refine the code by moving the definition of these
> > variables into fu540 and fu740 implementation respectively instead of
> > common core code, then we could still separate the SoCs-dependent data
> > in their own implementation.
> >
> > Fixes: 487dc7bb6a0c ("clk: sifive: fu540-prci: Declare static
> > const variable 'prci_clk_fu540' where it's used")
>
> The fixes tag should be on one line, not split across two.
>

Ok, let me fix it in the v4 patch. Thanks

> > Signed-off-by: Zong Li <zong.li at sifive.com>
> >



More information about the linux-riscv mailing list