[PATCH v3] clk: sifive: Fix W=1 kernel build warning

Zong Li zong.li at sifive.com
Fri Jan 7 01:05:43 PST 2022


On Fri, Jan 7, 2022 at 8:21 AM Stephen Boyd <sboyd at kernel.org> wrote:
>
> Quoting Zong Li (2022-01-05 21:58:28)
> > This commit reverts commit 487dc7bb6a0c ("clk: sifive: fu540-prci:
> > Declare static const variable 'prci_clk_fu540' where it's used").
> > For fixing W=1 kernel build warning(s) about ‘prci_clk_fu540’ defined
> > but not used [-Wunused-const-variable=], the problem is that the C file
> > of fu540 and fu740 doesn't use these variables, but they includes the
> > header files. We could refine the code by moving the definition of these
> > variables into fu540 and fu740 implementation respectively instead of
> > common core code, then we could still separate the SoCs-dependent data
> > in their own implementation.
> >
> > Changed in v3:
> >  - Rebase on v5.16-rc8
> >  - Add fixes tag
>
> Where?
>

Oops, I messed up on my local end. Please allow me to resend the v3 again.

> >
> > Changed in v2:
> >  - Move definition of variable to C file from header
>
> Please remove the changelog by putting it below the triple dash.
>

Thanks for your tips.

> >
> > Signed-off-by: Zong Li <zong.li at sifive.com>
> > ---
> >  drivers/clk/sifive/fu540-prci.c  |  6 +++++-
> >  drivers/clk/sifive/fu540-prci.h  |  6 +-----



More information about the linux-riscv mailing list