[PATCH v7 05/11] dt-bindings: pwm: add microchip corepwm binding

Krzysztof Kozlowski krzysztof.kozlowski at canonical.com
Tue Feb 22 23:12:49 PST 2022


On 23/02/2022 07:20, Uwe Kleine-König wrote:
> On Mon, Feb 14, 2022 at 01:58:35PM +0000, conor.dooley at microchip.com wrote:
>> From: Conor Dooley <conor.dooley at microchip.com>
>>
>> Add device tree bindings for the Microchip fpga fabric based "core" PWM
>> controller.
>>
>> Reviewed-by: Rob Herring <robh at kernel.org>
>> Signed-off-by: Conor Dooley <conor.dooley at microchip.com>
>> Acked-by: Palmer Dabbelt <palmer at rivosinc.com>
> 
> I like it:
> 
> Acked-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> 
> nitpick: Put your S-o-b last in the commit log. (This doesn't justify a
> resend IMHO)

It should be the opposite - the first. First author signs the patch,
then comes review and finally an ack. Putting SoB at then suggests that
tags were accumulated before sending patch, out of mailing list.


Best regards,
Krzysztof



More information about the linux-riscv mailing list