[PATCH] pinctrl: k210: Fix bias-pull-up
Sean Anderson
seanga2 at gmail.com
Wed Feb 9 10:29:05 PST 2022
On 2/9/22 1:28 PM, Sean Anderson wrote:
> Using bias-pull-up would actually cause the pin to have its pull-down
> enabled. Fix this.
>
> Signed-off-by: Sean Anderson <seanga2 at gmail.com>
> ---
>
> drivers/pinctrl/pinctrl-k210.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c
> index 49e32684dbb2..1ad61b32ec88 100644
> --- a/drivers/pinctrl/pinctrl-k210.c
> +++ b/drivers/pinctrl/pinctrl-k210.c
> @@ -527,7 +527,7 @@ static int k210_pinconf_set_param(struct pinctrl_dev *pctldev,
> case PIN_CONFIG_BIAS_PULL_UP:
> if (!arg)
> return -EINVAL;
> - val |= K210_PC_PD;
> + val |= K210_PC_PU;
> break;
> case PIN_CONFIG_DRIVE_STRENGTH:
> arg *= 1000;
>
This should have
Fixes: d4c34d09ab03 ("pinctrl: Add RISC-V Canaan Kendryte K210 FPIOA driver")
More information about the linux-riscv
mailing list