[PATCH v3 3/6] riscv: dts: microchip: fix board compatible
Geert Uytterhoeven
geert at linux-m68k.org
Tue Sep 21 04:46:22 PDT 2021
Hi Krzysztof,
On Mon, Sep 20, 2021 at 5:09 PM Krzysztof Kozlowski
<krzysztof.kozlowski at canonical.com> wrote:
> According to bindings, the compatible must include microchip,mpfs. This
> fixes dtbs_check warning:
>
> arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dt.yaml: /: compatible: ['microchip,mpfs-icicle-kit'] is too short
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at canonical.com>
Reviewed-by: Geert Uytterhoeven <geert at linux-m68k.org>
> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts
> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts
> @@ -10,7 +10,7 @@
>
> / {
> model = "Microchip PolarFire-SoC Icicle Kit";
> - compatible = "microchip,mpfs-icicle-kit";
> + compatible = "microchip,mpfs-icicle-kit", "microchip,mpfs";
>
> aliases {
> ethernet0 = &emac1;
> diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> index 93730afe6c58..5084b93188f0 100644
> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> @@ -7,7 +7,7 @@ / {
> #address-cells = <2>;
> #size-cells = <2>;
> model = "Microchip MPFS Icicle Kit";
Note that "model" should be "Microchip PolarFire SoC"
(with/without a hyphen? seems like the occurrence in
microchip-mpfs-icicle-kit.dts is the only one with a hyphen)
> - compatible = "microchip,mpfs-icicle-kit";
> + compatible = "microchip,mpfs";
>
> chosen {
> };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
More information about the linux-riscv
mailing list