[PATCH] riscv: remove unused SBI helpers and exports

Palmer Dabbelt palmer at dabbelt.com
Sat May 29 16:48:56 PDT 2021

On Thu, 27 May 2021 06:24:10 PDT (-0700), anup at brainfault.org wrote:
> On Thu, May 27, 2021 at 6:47 PM Christoph Hellwig <hch at lst.de> wrote:
>> On Thu, May 27, 2021 at 03:15:09PM +0200, Paolo Bonzini wrote:
>> >>> -EXPORT_SYMBOL(sbi_remote_hfence_vvma_asid);
>> >> All sbi_remote_hfence_xyz() calls are used by KVM RISC-V module.
>> >>
>> >
>> > Why aren't all these added by the series that add the module (not talking
>> > about KVM only)?
>> Yes, that is the way to do it.
> Actually SBI v0.2 RFENCE extension defines all these calls hence Atish
> added it as part of SBI v0.2 patches.
> All sbi_remote_hfence_xyz() are primarily for hypervisors only.

We took them early as a way to help make it easier to handle the KVM 
patches, as at the time these were the only things touching files 
outside of arch/riscv/kvm.

I know the general rule is to only take code with callers, but these are 
defined by the SBI so I figured we'd make everyone's lives a bit easier 
by just keeping them around.

More information about the linux-riscv mailing list