[PATCH v4 4/5] dt-bindings: add bindings for polarfire soc system controller

[Conor.Dooley at microchip.com]

On 11/03/2021 17:43, Rob Herring wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Thu, Mar 11, 2021 at 11:34:56AM +0000, conor.dooley at microchip.com wrote:
>> From: Conor Dooley <conor.dooley at microchip.com>
>>
>> Add device tree bindings for the MSS system controller on
>> the Microchip PolarFire SoC.
>>
>> Signed-off-by: Conor Dooley <conor.dooley at microchip.com>
>> ---
>>  ...icrochip,polarfire-soc-sys-controller.yaml | 36 +++++++++++++++++++
>>  1 file changed, 36 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/soc/microchip/microchip,polarfire-soc-sys-controller.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/soc/microchip/microchip,polarfire-soc-sys-controller.yaml b/Documentation/devicetree/bindings/soc/microchip/microchip,polarfire-soc-sys-controller.yaml
>> new file mode 100644
>> index 000000000000..222557f96a13
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/soc/microchip/microchip,polarfire-soc-sys-controller.yaml
>> @@ -0,0 +1,36 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/soc/microchip/microchip,polarfire-soc-sys-controller.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>> +
>> +title: Microchip PolarFire SoC (MPFS) MSS (microprocessor subsystem) system controller
>> +
>> +maintainers:
>> +  - Conor Dooley <conor.dooley at microchip.com>
>> +
>> +description: |
>> +  The PolarFire SoC system controller can be accessed as a mailbox device.
>> +  This document describes the bindings for that device.
>> +
>> +
>> +properties:
>> +
>> +  allOf:
>> +    - $ref: /schemas/mbox/mbox-consumer.yaml#properties
> This defines a DT property 'allOf'. This would need to be at the top
> level with 'properties' dropped. However, you generally don't want to
> include consumer schemas. You need to define 'mboxes' property here
> because you need to define how many and what they are if more than 1.

In a previous version i was defining it like the below, but you didnt like the redefinition of the common property.
Is there something in between the two that you are looking for?

  mboxes:
    maxItems: 1
    description: |
      phandle and index of the mailbox controller device node.

>
> What does 'can be accessed as a mailbox device' mean? Is there another
> way? Is it a mailbox device (provider)?
this is the bindings for the mailbox client, ill rephrase the description and make it clearer.
>
>> +
>> +  compatible:
>> +    const: microchip,polarfire-soc-sys-controller
>> +
>> +required:
>> +  - compatible
>> +  - mboxes
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    syscontroller: syscontroller {
>> +      compatible = "microchip,polarfire-soc-sys-controller";
>> +      mboxes = <&mbox 0>;
>> +    };
>> --
>> 2.17.1
>>