[PATCH] drivers: gpio: add virtio-gpio guest driver
Enrico Weigelt, metux IT consult
lkml at metux.net
Wed Jun 16 08:04:30 PDT 2021
On 16.06.21 13:49, Viresh Kumar wrote:
> I am not looking to get any credits for the code or spec here. I don't
> really care about that. For the very same reason I kept you as the
> author of the 1st patch in the kernel series, so git keeps showing you
> as the original author.
Fine, and I'm not intenting to fight over credits. I'm just interested
in having a solid solution.
> All I wanted to work on was the backend (in rust).
Okay, but why did you change the whole thing into something completely
> You only ever sent 1 real versions of the Linux driver, that too
> "6-months-back", there were no real blockers anywhere and you never
> attempted to upstream anything.
The backlog was in the maillist archive. It was just lingering because
of yet missing formal registering w/ vitio TC and I've been to busy with
more pressing tasks. (for example I've got keep public infrastructure
stuff up and running while folks are in lockdown).
> Similarly, you "never" sent the specification properly to the virtio
> lists for review. You sent it once as an attachment to an email, which
> no one ever received.
Half correct: I sent it to the list, but this wasn't tex'ified yet.
> When I tried to move this forward, invested a lot of time into making
> it better from specification to code, reviews started happening, you
> decided to start blocking it again.
When we had an email conversation about this, it was about submitting
the existing spec in a formal correct way. Don't get me wrong: I
apreciate that somebody's doing the beaurocratic work. But still have
no idea why you changed it completely, so there's quite nothing left
but the name and that it somehow does gpio via virtio.
> Linux upstream doesn't really care about this, you can ask any Linux
> Maintainer about this.
I happen to be a maintainer myself, and we do actually care about
whether some thing is well tested.
> If your code and specification isn't doing the
> right thing, and isn't good enough, you will be asked to update it
> upon reviews.
Okay, please tell me, where exactly isn't right and why so.
> YOU JUST CAN'T SAY I WON'T because I have products based on this
Most of driver development goes pretty much like this. Yes, we would
prefer HW and FW vendors to talk with us first, but that rarely happens.
>>> * virtio spec has been submitted to virtio TC
> Which specification are you talking about here ? The only
> specification I can see on virtio lists is the one I sent.
The one I've resent (now texified) a few days ago. It had been submitted
in ascii form last year. The answer from virtio TC folks whas that there
are some formal steps to be done and it needs to be patched int their
> And the driver you tried to send isn't aligned to that for sure, and
> it takes us back from all the improvements I tried to do.
Which improvements, exactly ? Unfortunately, you never talked to me
what exactly you've been missing.
I really have no idea, why you just
> I am not saying that my version of the specification is the best and
> there is no flaw in it.
I did outline several problems of your spec on virtio list. Things that
already had already incorporated in my original one.
Really, I have no idea why you've never talked to me on specific issues,
but instead threw away, made something completely different and even
claim it would be just kinda "minor upgrade" of mine. WTF ?!
> There is no point going backwards now after making so much of
> progress. Even if you try to send your version, it will slowly and
> slowly reach very close to my latest version of code and spec.
Or the other way round, as soon as silicon guys come in and see how
complicated and expensive your approach becomes.
> Because your version of the code and spec weren't good enough for everyone.
Again, please tell me what exactly was not "good enought" and who
exactly is "everyone".
> You need to accept that changes to that are inevitable since there
You sound like a politician that tries to push an hidden agenda,
made by some secret interest group in the back room, against the
people - like "resistance is futile".
Finally, please tell me what exactly you're missing so hard in my spec,
that really needs a completely different implementation, which is hard
and expensive to implement in hardware.
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info at metux.net -- +49-151-27565287
More information about the linux-riscv