[PATCH] RISC-V: Make NUMA depend on SMP

Palmer Dabbelt palmer at dabbelt.com
Fri Feb 26 22:07:25 EST 2021


On Fri, 26 Feb 2021 17:03:53 PST (-0800), wangkefeng.wang at huawei.com wrote:
>
> On 2021/2/27 4:25, Palmer Dabbelt wrote:
>> From: Palmer Dabbelt <palmerdabbelt at google.com>
>>
>> In theory these are orthogonal, but in practice all NUMA systems are
>> SMP.  NUMA && !SMP doesn't build, everyone else is coupling them, and I
>> don't really see any value in supporting that configuration.
>>
>> Fixes: 4f0e8eef772e ("riscv: Add numa support for riscv64 platform")
>> Suggested-by: Andrew Morton <akpm at linux-foundation.org>
>> Suggested-by: Atish Patra <atishp at atishpatra.org>
>> Signed-off-by: Palmer Dabbelt <palmerdabbelt at google.com>
>
> Reported-and-Tested-by:  Kefeng Wang <wangkefeng.wang at huawei.com>

Ah, thanks, I forged I'd said no to this earlier ;)

>
>
>> ---
>> This is on fixes.
>> ---
>>   arch/riscv/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
>> index a998babc1237..85d626b8ce5e 100644
>> --- a/arch/riscv/Kconfig
>> +++ b/arch/riscv/Kconfig
>> @@ -314,6 +314,7 @@ endchoice
>>   # Common NUMA Features
>>   config NUMA
>>   	bool "NUMA Memory Allocation and Scheduler Support"
>> +	depends on SMP
>>   	select GENERIC_ARCH_NUMA
>>   	select OF_NUMA
>>   	select ARCH_SUPPORTS_NUMA_BALANCING



More information about the linux-riscv mailing list