[PATCH 05/13] riscv: compat: syscall: Add compat_sys_call_table implementation

Arnd Bergmann arnd at arndb.de
Wed Dec 22 06:00:16 PST 2021


On Wed, Dec 22, 2021 at 2:21 PM Arnd Bergmann <arnd at arndb.de> wrote:
> On Wed, Dec 22, 2021 at 1:43 PM Guo Ren <guoren at kernel.org> wrote:
>
> Right, I think the patch would be a nice cleanup, but it appears that
> riscv is among the few architectures that have defined their own
> nonstandard mmap2() syscall after all, despite using the standard
> name for the entry point. Not sure how this slipped past my original
> review, but it certainly can't be changed now.

No, I misread, the calling conventions are fine after all, it's
just written in a rather odd way.

> Maybe leave it there and change the #ifdef to build mmap2 for both
> native rv32 and compat mode.

This bit still applies though, I don't think you need to add another
helper, just use the one that is already there.

        Arnd



More information about the linux-riscv mailing list